From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QwD4N-0004gQ-DX
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:00:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QwD4I-0006OB-En
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:00:35 -0400
Received: from thoth.sbs.de ([192.35.17.2]:24427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QwD4I-0006Nh-20
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:00:30 -0400
Message-ID: <4E54F5E9.1020104@siemens.com>
Date: Wed, 24 Aug 2011 15:00:25 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1314187627-20975-1-git-send-email-avi@redhat.com>
	<4E54F2A2.6000100@siemens.com> <4E54F57D.8070809@redhat.com>
In-Reply-To: <4E54F57D.8070809@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vga: squash build error in
	vga_update_memory_access()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2011-08-24 14:58, Avi Kivity wrote:
> On 08/24/2011 03:46 PM, Jan Kiszka wrote:
>>>  +++ b/hw/vga.c
>>>  @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s)
>>>               base = 0xb8000;
>>>               size = 0x8000;
>>>               break;
>>>  +        default:
>>>  +            abort();
>>>           }
>>>           region = g_malloc(sizeof(*region));
>>>           memory_region_init_alias(region, "vga.chain4",&s->vram, offset, size);
>>
>> ...or just make the last case default?
>>
> 
> No reason to make the code unobvious in this path, IMO.  Eventually gcc 
> will be able to drop the 4/5 bytes this patch adds to the object code.

diff --git a/hw/vga.c b/hw/vga.c
index 851fd68..125fb29 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -176,6 +176,7 @@ static void vga_update_memory_access(VGACommonState *s)
             size = 0x8000;
             break;
         case 3:
+        default:
             base = 0xb8000;
             size = 0x8000;
             break;

...is fairly common and well readable IMHO.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux