From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwDAO-00085X-58 for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:06:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwDAJ-0007go-C2 for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:06:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwDAJ-0007gf-4D for qemu-devel@nongnu.org; Wed, 24 Aug 2011 09:06:43 -0400 Message-ID: <4E54F75E.7090502@redhat.com> Date: Wed, 24 Aug 2011 16:06:38 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312831898-18702-1-git-send-email-aliguori@us.ibm.com> <4E54C8C3.4050609@redhat.com> <4E54F0BA.60106@us.ibm.com> <4E54F4CE.3030309@redhat.com> <4E54F66B.40000@codemonkey.ws> In-Reply-To: <4E54F66B.40000@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lucas Meneghel Rodrigues , Anthony Liguori , qemu-devel@nongnu.org On 08/24/2011 04:02 PM, Anthony Liguori wrote: >> Too subtle, IMO. I understand that we want to avoid a full qmp parser >> for one-off unit tests, but using bit fields in the exit code? >> >> Perhaps a python script that launches qemu with qmp and -no-shutdown, >> listens for the guest shutdown event, and prints out the result? That >> can be easily reused in test scripts. > > > How can the test pass data via shutdown? You would need a scratch > register of some form I think... I meant using the port in the patch. Just replace exit() with the ordinary shutdown path - notifications, and not exiting if -no-shutdown is requested. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.