From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwGzd-0003LX-2s
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:11:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwGzb-0007qQ-Tf
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:11:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6036)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwGzb-0007qA-Ie
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:11:55 -0400
Message-ID: <4E5530D8.2060207@redhat.com>
Date: Wed, 24 Aug 2011 20:11:52 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1314193259-27092-1-git-send-email-avi@redhat.com>
	<1314193259-27092-9-git-send-email-avi@redhat.com>
	<4E552E4B.8060505@twiddle.net>
In-Reply-To: <4E552E4B.8060505@twiddle.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/22] sysbus:
	add	sysbus_add_memory_overlap()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 08/24/2011 08:00 PM, Richard Henderson wrote:
> On 08/24/2011 03:40 AM, Avi Kivity wrote:
> >  +void sysbus_add_memory_overlap(SysBusDevice *dev, target_phys_addr_t addr,
> >  +                               MemoryRegion *mem, unsigned priority)
> >  +{
> >  +    memory_region_add_subregion(get_system_memory(), addr, mem);
> >  +}
> >  +
>
> memory_region_add_subregion_overlap, with "priority" actually used, surely?
>
>

Shirley can't write any code.  I'll fix it up.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.