From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QwZ17-0001ql-NQ
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 08:26:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QwZ16-0000dS-UK
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 08:26:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QwZ16-0000dK-NG
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 08:26:40 -0400
Message-ID: <4E564030.7010204@redhat.com>
Date: Thu, 25 Aug 2011 14:29:36 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1314211389-28915-1-git-send-email-aliguori@us.ibm.com>
	<1314211389-28915-10-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1314211389-28915-10-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add
	set-blockdev-password
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Am 24.08.2011 20:43, schrieb Anthony Liguori:
> block_passwd is unfortunately named so while converting block_passwd to QAPI,
> introduce a more properly named alias.
> 
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

I'm not sure if I like the set-blockdev-password alias, for two reasons.

The first one is that blockdev_* is supposed to be the new, clean
interface, so I wouldn't add similarly named commands without having a
look at the big picture. For example, what again was the reason for
having the password separate from other block device options?

The second one is that names like set-foo, get-foo and frob-foo make it
very hard to see what I can do with a foo. If they are called as today
(drive_add, drive_del) and ideally use a consistent prefix (unlike
drive_*, block_*, snapshot_blkdev today), you'll find all of them in the
same place in the documentation and in HMP typing blockdev_<TAB> will
show you everything you can do with a block device.

Kevin