From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZdT-0000jS-KV
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:06:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZdS-0002Y2-Lv
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:06:19 -0400
Received: from e36.co.us.ibm.com ([32.97.110.154]:59977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZdS-0002Xu-AD
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:06:18 -0400
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e36.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7PCxkpH027010
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 06:59:46 -0600
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p7PD6E8j111118
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 07:06:14 -0600
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p7PD6Dd9008432
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 07:06:14 -0600
Message-ID: <4E5648C4.3000604@us.ibm.com>
Date: Thu, 25 Aug 2011 08:06:12 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>
	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>
	<4E564254.2080204@web.de>
In-Reply-To: <4E564254.2080204@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/25/2011 07:38 AM, Jan Kiszka wrote:
> On 2011-08-25 14:02, TeLeMan wrote:
>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<jan.kiszka@web.de>  wrote:
>>> What a mess. Do we really have to go through all 257 packed data structs
>>> in QEMU and add these MS compat bits to all potentially affected ones?
>> I prefer to detect -mms-bitfields and remove it in configure.
>
> /me too - if that is possible, ie. if the glib bits we are using doesn't
> require us to apply that mode. Can anyone comment on this?

So why can't we just #pragma guard all of the slirp bits?  Why are we 
doing it on a per data structure basis?

Regards,

Anthony Liguori

>
> Jan
>