From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZeb-00020v-Oe
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:07:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZea-0002kM-Qm
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:07:29 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:52804)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QwZea-0002kI-OK
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:07:28 -0400
Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147])
	by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7PCjaSj031406
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 08:45:36 -0400
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p7PD7R5d2695314
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 09:07:27 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p7P97EXb016904
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 06:07:14 -0300
Message-ID: <4E564909.6010105@us.ibm.com>
Date: Thu, 25 Aug 2011 08:07:21 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>
	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>	<4E564254.2080204@web.de>
	<4E5647F0.1080806@redhat.com>
In-Reply-To: <4E5647F0.1080806@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>

On 08/25/2011 08:02 AM, Avi Kivity wrote:
> On 08/25/2011 03:38 PM, Jan Kiszka wrote:
>> >>
>> >> What a mess. Do we really have to go through all 257 packed data
>> structs
>> >> in QEMU and add these MS compat bits to all potentially affected ones?
>> > I prefer to detect -mms-bitfields and remove it in configure.
>
> Can use -mno-ms-bitfields later to override it.

No, we can't do that.

The reason glib uses -mms-bitfields is that you need to use it in order 
to call Windows APIs which is does.  We will eventually need to do it 
anyway.

>
>> /me too - if that is possible, ie. if the glib bits we are using doesn't
>> require us to apply that mode. Can anyone comment on this?
>>
>
> I'd shy away from that. Even if it works now it may break later.
>
> We should simply avoid bitfields on externally-defined formats;
> meanwhile we can use __attribute__((gcc_struct)) and keep using those we
> have already.

+1

Regards,

Anthony Liguori


>