From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwZoi-0008MG-7a
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:17:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwZoh-0004oS-At
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:17:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwZoh-0004mY-1y
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:17:55 -0400
Message-ID: <4E564B7E.5030202@redhat.com>
Date: Thu, 25 Aug 2011 16:17:50 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>
	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>	<4E564254.2080204@web.de>
	<4E5647F0.1080806@redhat.com> <4E564909.6010105@us.ibm.com>
	<4E56498D.8080505@web.de>
In-Reply-To: <4E56498D.8080505@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/25/2011 04:09 PM, Jan Kiszka wrote:
> >>
> >>  We should simply avoid bitfields on externally-defined formats;
> >>  meanwhile we can use __attribute__((gcc_struct)) and keep using those we
> >>  have already.
> >
> >  +1
>
> We aren't discussing bitfields anymore but essential unaligned (and
> therefore packed) protocol structs.
>
> And I'm not that much worried about going through the few slirp structs
> but all the other 250 packed ones in entire QEMU.
>

AFICT gcc_struct is also about alignment, so it should just_work.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.