From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZqM-0001Ar-Pu for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:19:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwZqL-0005LV-Ro for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:19:38 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:59795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZqL-0005LC-CZ for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:19:37 -0400 Message-ID: <4E564BE7.3030700@web.de> Date: Thu, 25 Aug 2011 15:19:35 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E48BF2F.7080901@web.de> <4E501243.2090806@mail.berlios.de> <4E54C045.9020007@web.de> <4E562C38.3010908@web.de> <4E564254.2080204@web.de> <4E5647F0.1080806@redhat.com> <4E564909.6010105@us.ibm.com> <4E564AD6.7040307@redhat.com> In-Reply-To: <4E564AD6.7040307@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2B23E3E10A18093EFEA9DC45" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , TeLeMan , Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2B23E3E10A18093EFEA9DC45 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-08-25 15:15, Avi Kivity wrote: > On 08/25/2011 04:07 PM, Anthony Liguori wrote: >> On 08/25/2011 08:02 AM, Avi Kivity wrote: >>> On 08/25/2011 03:38 PM, Jan Kiszka wrote: >>>> >> >>>> >> What a mess. Do we really have to go through all 257 packed data >>>> structs >>>> >> in QEMU and add these MS compat bits to all potentially affected >>>> ones? >>>> > I prefer to detect -mms-bitfields and remove it in configure. >>> >>> Can use -mno-ms-bitfields later to override it. >> >> No, we can't do that. >> >> The reason glib uses -mms-bitfields is that you need to use it in >> order to call Windows APIs which is does. We will eventually need to >> do it anyway. >=20 > I meant, just for our own objects. As long as there are no glib APIs > which use bitfields, it should work. >=20 > However, I don't like it either, and prefer the > __attribute__(((((((gcc_fields)))))) as well. Could someone with a Windows environment test if that (or (packed, gcc_fields)?) makes struct { unsigned char a; unsigned int b; }; truly packed again? Jan --------------enig2B23E3E10A18093EFEA9DC45 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5WS+cACgkQitSsb3rl5xTIFACgr/4DgXt2eWVXwNheoZtrTh7N 978An1/FaEhZPLH9GqxEc1owjopWRyts =E/Lw -----END PGP SIGNATURE----- --------------enig2B23E3E10A18093EFEA9DC45--