From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QwZzP-0000DS-S0
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:29:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QwZzO-0007B8-Vm
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:28:59 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:63195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QwZzO-0007Av-TI
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:28:58 -0400
Received: by yxt3 with SMTP id 3so1965073yxt.4
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 06:28:58 -0700 (PDT)
Message-ID: <4E564E18.7090802@codemonkey.ws>
Date: Thu, 25 Aug 2011 08:28:56 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>	<4E564254.2080204@web.de>
	<4E5648C4.3000604@us.ibm.com> <4E564A72.6080108@web.de>
In-Reply-To: <4E564A72.6080108@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/25/2011 08:13 AM, Jan Kiszka wrote:
> On 2011-08-25 15:06, Anthony Liguori wrote:
>> On 08/25/2011 07:38 AM, Jan Kiszka wrote:
>>> On 2011-08-25 14:02, TeLeMan wrote:
>>>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<jan.kiszka@web.de>   wrote:
>>>>> What a mess. Do we really have to go through all 257 packed data
>>>>> structs
>>>>> in QEMU and add these MS compat bits to all potentially affected ones?
>>>> I prefer to detect -mms-bitfields and remove it in configure.
>>>
>>> /me too - if that is possible, ie. if the glib bits we are using doesn't
>>> require us to apply that mode. Can anyone comment on this?
>>
>> So why can't we just #pragma guard all of the slirp bits?  Why are we
>> doing it on a per data structure basis?
>
> Packing all structs is not really a good idea, more a last resort.

It doesn't force packing, it forces GCC style structure layout.

Regards,

Anthony Liguori

> Jan
>