From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwa3f-0005Yt-2T for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwa3d-0008GI-RR for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:33:23 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:42886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwa3d-0008GA-Du for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:33:21 -0400 Message-ID: <4E564F06.7040304@web.de> Date: Thu, 25 Aug 2011 15:32:54 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E48BF2F.7080901@web.de> <4E501243.2090806@mail.berlios.de> <4E54C045.9020007@web.de> <4E562C38.3010908@web.de> <4E564254.2080204@web.de> <4E5648C4.3000604@us.ibm.com> <4E564A72.6080108@web.de> <4E564E18.7090802@codemonkey.ws> In-Reply-To: <4E564E18.7090802@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig109061BF46372F27FD41989A" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , TeLeMan , Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig109061BF46372F27FD41989A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-08-25 15:28, Anthony Liguori wrote: > On 08/25/2011 08:13 AM, Jan Kiszka wrote: >> On 2011-08-25 15:06, Anthony Liguori wrote: >>> On 08/25/2011 07:38 AM, Jan Kiszka wrote: >>>> On 2011-08-25 14:02, TeLeMan wrote: >>>>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka wrot= e: >>>>>> What a mess. Do we really have to go through all 257 packed data >>>>>> structs >>>>>> in QEMU and add these MS compat bits to all potentially affected >>>>>> ones? >>>>> I prefer to detect -mms-bitfields and remove it in configure. >>>> >>>> /me too - if that is possible, ie. if the glib bits we are using >>>> doesn't >>>> require us to apply that mode. Can anyone comment on this? >>> >>> So why can't we just #pragma guard all of the slirp bits? Why are we= >>> doing it on a per data structure basis? >> >> Packing all structs is not really a good idea, more a last resort. >=20 > It doesn't force packing, it forces GCC style structure layout. If we are talking about #pragma pack(...), then that's not what I read in the docs. Jan --------------enig109061BF46372F27FD41989A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5WTwYACgkQitSsb3rl5xRUDQCgixea/FiaPef0+Qlq48fTpLUw VHsAn3xUQwHeuNc3VyGSZepCmhUTgYEf =8qc8 -----END PGP SIGNATURE----- --------------enig109061BF46372F27FD41989A--