From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qwapv-0003wy-Nd
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:23:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qwapu-0001Ny-P1
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:23:15 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:47407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Qwapu-0001NQ-MX
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:23:14 -0400
Received: by ywf9 with SMTP id 9so2010953ywf.4
	for <qemu-devel@nongnu.org>; Thu, 25 Aug 2011 07:23:14 -0700 (PDT)
Message-ID: <4E565ACE.7030607@codemonkey.ws>
Date: Thu, 25 Aug 2011 09:23:10 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>	<4E564254.2080204@web.de>	<4E5648C4.3000604@us.ibm.com>	<4E564A72.6080108@web.de>	<4E564E18.7090802@codemonkey.ws>	<4E564F06.7040304@web.de>
	<4E565637.8030909@mail.berlios.de>
In-Reply-To: <4E565637.8030909@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>

On 08/25/2011 09:03 AM, Stefan Weil wrote:
> As I wrote in my last mail, I compared all structs without and with
> -mms-bitfields
> using pahole and codiff. The result is in the appended codiff.log.
>
> About 17 structs changed because of -mms-bitfield. This attribute
> modifies not only
> structs with bitfield but also packed structs or structs with other
> attributes
> like TCGPool.
>
> Jan's patch fixed slirp bitfields. For the remaining cases, I also
> thought about
> removing -mms-bitfield or setting a pragma in qemu-common.h, but now I
> prefer a different solution: replace all __attribute__(packed),
> __attribute(__packed__)
> by QEMU_PACKED.
>
> QEMU_PACKED will be a macro defined in compiler.h which sets the attributes
> needed (also for w32 with -mms-bitfields).

That sounds like a good idea.

Regards,

Anthony Liguori

>
> Maybe I can send patches with the changes needed next weekend if
> everybody agrees
> to this solution.
>
> Cheers,
> Stefan
>