From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwb1M-00084I-Le for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:35:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwb1L-0003wq-Dh for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:35:04 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:42148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwb1L-0003wl-5V for qemu-devel@nongnu.org; Thu, 25 Aug 2011 10:35:03 -0400 Received: by qyk31 with SMTP id 31so1690891qyk.4 for ; Thu, 25 Aug 2011 07:35:02 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E565D90.1050208@redhat.com> Date: Thu, 25 Aug 2011 16:34:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1314257035-7328-1-git-send-email-freddy77@gmail.com> In-Reply-To: <1314257035-7328-1-git-send-email-freddy77@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: use always stderr for debugging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 08/25/2011 09:23 AM, Frediano Ziglio wrote: > let all DEBUG_ALLOC2 printf goes to stderr > > Signed-off-by: Frediano Ziglio > --- > block/qcow2-cluster.c | 2 +- > block/qcow2-refcount.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index 9269dda..9034840 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -53,7 +53,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size, bool exact_size) > } > > #ifdef DEBUG_ALLOC2 > - printf("grow l1_table from %d to %d\n", s->l1_size, new_l1_size); > + fprintf(stderr, "grow l1_table from %d to %d\n", s->l1_size, new_l1_size); > #endif > > new_l1_size2 = sizeof(uint64_t) * new_l1_size; > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 2a915be..fbf28da 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -422,7 +422,7 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, > int ret; > > #ifdef DEBUG_ALLOC2 > - printf("update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n", > + fprintf(stderr, "update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n", > offset, length, addend); > #endif > if (length< 0) { > @@ -556,7 +556,7 @@ retry: > } > } > #ifdef DEBUG_ALLOC2 > - printf("alloc_clusters: size=%" PRId64 " -> %" PRId64 "\n", > + fprintf(stderr, "alloc_clusters: size=%" PRId64 " -> %" PRId64 "\n", > size, > (s->free_cluster_index - nb_clusters)<< s->cluster_bits); > #endif Adding trace events would be even better, no? Paolo