From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwice-00071v-BB for qemu-devel@nongnu.org; Thu, 25 Aug 2011 18:42:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwicc-0001kA-Ot for qemu-devel@nongnu.org; Thu, 25 Aug 2011 18:42:04 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:41630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwicc-0001k5-MM for qemu-devel@nongnu.org; Thu, 25 Aug 2011 18:42:02 -0400 Received: by gyd12 with SMTP id 12so2504573gyd.4 for ; Thu, 25 Aug 2011 15:42:01 -0700 (PDT) Message-ID: <4E56CFB6.8000908@codemonkey.ws> Date: Thu, 25 Aug 2011 17:41:58 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314187627-20975-1-git-send-email-avi@redhat.com> <4E54F2A2.6000100@siemens.com> <4E54F57D.8070809@redhat.com> <4E54F5E9.1020104@siemens.com> <4E556681.2060207@codemonkey.ws> <4E561175.8080800@siemens.com> In-Reply-To: <4E561175.8080800@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vga: Silence bogus gcc warning about uninitialized variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Avi Kivity , "qemu-devel@nongnu.org" On 08/25/2011 04:10 AM, Jan Kiszka wrote: > Some gcc versions do not properly detect that all possible cases are > covered and base and size are always initialized. Please gcc by defining > a pseudo default case. > > Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > hw/vga.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/vga.c b/hw/vga.c > index 851fd68..125fb29 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -176,6 +176,7 @@ static void vga_update_memory_access(VGACommonState *s) > size = 0x8000; > break; > case 3: > + default: > base = 0xb8000; > size = 0x8000; > break;