From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwu9L-0003Kn-EQ for qemu-devel@nongnu.org; Fri, 26 Aug 2011 07:00:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwu9K-0002ug-7D for qemu-devel@nongnu.org; Fri, 26 Aug 2011 07:00:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwu9J-0002uQ-Sk for qemu-devel@nongnu.org; Fri, 26 Aug 2011 07:00:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QB0WIc009288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Aug 2011 07:00:32 -0400 Message-ID: <4E577CCD.2080001@redhat.com> Date: Fri, 26 Aug 2011 13:00:29 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1313773728-6104-1-git-send-email-alevy@redhat.com> <4E576D69.8020103@redhat.com> <20110826100338.GH3944@redhat.com> <4E5772D6.1090304@redhat.com> <20110826104342.GY6393@bow.redhat.com> In-Reply-To: <20110826104342.GY6393@bow.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org, Alon Levy Hi, >> Ok, so I think we should be able to fix the race outlined above >> without adding new monitor commands, just by letting libvirt set the >> spice ticket in stage 2. > > Is that different then what I suggested in my reply to Daniel's 5 stage outline? I think we have to care to not mix up switch-host and seamless spice client migration, your reply seems to refer top some seamless spice migration implementation ideas. Today we seem to have this workflow: (1) migration src->dst (stage 3) (2a) libvirt sets spice ticket at dst (not sure which stage) (2b) spice client switches connection to dst 2a and 2b are racing here. I think we can fix the race by doing this instead: (1) libvirt sets spice ticket at dst (stage 2) (2) migration src->dst (stage 3) (3) spice client switches connection to dst cheers, Gerd