qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)
Date: Fri, 26 Aug 2011 14:39:59 +0200	[thread overview]
Message-ID: <4E57941F.1060403@redhat.com> (raw)
In-Reply-To: <20110826110459.GK3944@redhat.com>

>>    (1) libvirt sets spice ticket at dst (stage 2)
>>    (2) migration src->dst (stage 3)
>>    (3) spice client switches connection to dst
>
> This is actually what we have already. The problem is that
> the 'migration src->dst' here can take an arbitrary amount
> of time. So by the time the spice client switchs to dst,
> the ticket will likely have already expired.

Ah, *that* is the bug.

> The only way to fix this AFAICT is to ensure the SPICE
> client connects to dst before migration starts, but delays
> display switch until the end. eg
>
>      (1) libvirt sets spice ticket at dst (libvirt stage 2)
>      (2) spice client connects to dst (start of libvirt stage 3)

That must be in stage 2.  Once the migration started qemu will not 
accept new connections and thus the client would not be able to connect.

Can qemu handle async monitor commands now?  We would need to wait until 
the client has actually connected, but without blocking the iothread 
because it can take a while.

cheers,
   Gerd

  reply	other threads:[~2011-08-26 12:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 17:08 [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009) Alon Levy
2011-08-19 17:08 ` [Qemu-devel] [PATCH 1/3] monitor: refactor whitespace and optional argument parsing Alon Levy
2011-08-19 17:08 ` [Qemu-devel] [PATCH 2/3] spice-core: client_migrate_info: add optional auto_switch parameter (RHBZ 725009) Alon Levy
2011-08-19 17:08 ` [Qemu-devel] [PATCH 3/3] monitor: add client_migrate_switch command " Alon Levy
2011-08-26  9:54 ` [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch " Gerd Hoffmann
2011-08-26 10:03   ` Daniel P. Berrange
2011-08-26 10:17     ` Gerd Hoffmann
2011-08-26 10:43       ` Alon Levy
2011-08-26 11:00         ` Gerd Hoffmann
2011-08-26 11:04           ` Daniel P. Berrange
2011-08-26 12:39             ` Gerd Hoffmann [this message]
2011-08-26 13:13               ` Daniel P. Berrange
2011-08-26 10:23     ` Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E57941F.1060403@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).