From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwvhe-0002Wh-0N for qemu-devel@nongnu.org; Fri, 26 Aug 2011 08:40:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwvhb-00051L-Sv for qemu-devel@nongnu.org; Fri, 26 Aug 2011 08:40:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwvhb-00050t-Ho for qemu-devel@nongnu.org; Fri, 26 Aug 2011 08:40:03 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QCe2s8007174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Aug 2011 08:40:02 -0400 Message-ID: <4E57941F.1060403@redhat.com> Date: Fri, 26 Aug 2011 14:39:59 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1313773728-6104-1-git-send-email-alevy@redhat.com> <4E576D69.8020103@redhat.com> <20110826100338.GH3944@redhat.com> <4E5772D6.1090304@redhat.com> <20110826104342.GY6393@bow.redhat.com> <4E577CCD.2080001@redhat.com> <20110826110459.GK3944@redhat.com> In-Reply-To: <20110826110459.GK3944@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Alon Levy , qemu-devel@nongnu.org >> (1) libvirt sets spice ticket at dst (stage 2) >> (2) migration src->dst (stage 3) >> (3) spice client switches connection to dst > > This is actually what we have already. The problem is that > the 'migration src->dst' here can take an arbitrary amount > of time. So by the time the spice client switchs to dst, > the ticket will likely have already expired. Ah, *that* is the bug. > The only way to fix this AFAICT is to ensure the SPICE > client connects to dst before migration starts, but delays > display switch until the end. eg > > (1) libvirt sets spice ticket at dst (libvirt stage 2) > (2) spice client connects to dst (start of libvirt stage 3) That must be in stage 2. Once the migration started qemu will not accept new connections and thus the client would not be able to connect. Can qemu handle async monitor commands now? We would need to wait until the client has actually connected, but without blocking the iothread because it can take a while. cheers, Gerd