From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33899)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qx2cx-0008Cw-UC
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 16:03:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qx2cx-0006bB-0r
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 16:03:43 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:61043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qx2cw-0006b7-Uj
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 16:03:42 -0400
Received: by vws17 with SMTP id 17so3601448vws.4
	for <qemu-devel@nongnu.org>; Fri, 26 Aug 2011 13:03:42 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E57FC17.1080405@twiddle.net>
Date: Fri, 26 Aug 2011 10:03:35 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1314308722-14495-1-git-send-email-rth@twiddle.net>	<1314308722-14495-7-git-send-email-rth@twiddle.net>	<CAFEAcA-HCUwc2-LF9RV3j7pE-QKjuY1VsfX8XJ7sb48e0fO+dw@mail.gmail.com>	<4E576264.2050200@redhat.com>	<4E57C9AC.4040703@twiddle.net>
	<CAFEAcA8XgcmK+Gn1ra6W2UiAeZqF5SV3Kc90z=yC3PuV83yrZg@mail.gmail.com>
In-Reply-To: <CAFEAcA8XgcmK+Gn1ra6W2UiAeZqF5SV3Kc90z=yC3PuV83yrZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/6] target-alpha: Add high-resolution
 access to wall clock and an alarm.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 08/26/2011 06:36 AM, Peter Maydell wrote:
> Look at the way target-i386 and target-mips use gen_io_start()
> and gen_io_end() around x86 io insns and MIPS mtc0. I think
> that what you need is (a) to bracket with gen_io_start/end
> and (b) to end the translation block, but that's really just
> guesswork from the existing code...

I'll be applying this on top of 6/6.  Look sane?


r~

---
diff --git a/target-alpha/translate.c b/target-alpha/translate.c
index 37f2f20..8f0dc3e 100644
--- a/target-alpha/translate.c
+++ b/target-alpha/translate.c
@@ -1609,7 +1609,17 @@ static void gen_mfpr(int ra, int regno)
 
     if (regno == 250) {
         /* WALL_TIME */
-        gen_helper_get_time(cpu_ir[ra]);
+        if (use_iocount) {
+            /* Mark as an IO operation because we read the time.  */
+            gen_io_start();
+            gen_helper_get_time(cpu_ir[ra]);
+            gen_io_end();
+            /* Other targets break the TB to be able to take timer
+               interrupts immediately.  This doesn't apply to Alpha
+               because we never take interrupts in PALmode.  */
+        } else {
+            gen_helper_get_time(cpu_ir[ra]);
+        }
         return;
     }
 
@@ -1661,7 +1671,14 @@ static ExitStatus gen_mtpr(DisasContext *ctx, int rb, int regno)
 
     case 251:
         /* ALARM */
-        gen_helper_set_alarm(tmp);
+        if (use_icount) {
+            /* Mark as an IO operation because we reference the time.  */
+            gen_io_start();
+            gen_helper_set_alarm(tmp);
+            gen_io_end();
+        } else {
+            gen_helper_set_alarm(tmp);
+        }
         break;
 
     default: