From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43859)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxa8z-000463-C9
	for qemu-devel@nongnu.org; Sun, 28 Aug 2011 03:51:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxa8y-0001O8-Gl
	for qemu-devel@nongnu.org; Sun, 28 Aug 2011 03:51:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxa8y-0001O1-9u
	for qemu-devel@nongnu.org; Sun, 28 Aug 2011 03:51:00 -0400
Message-ID: <4E59F359.9040506@redhat.com>
Date: Sun, 28 Aug 2011 10:50:49 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20110704094358.GA10960@redhat.com>
	<4E4B7DE1.3050405@cn.fujitsu.com>
	<4E4C8577.5000608@cn.fujitsu.com> <4E4D2C9F.6040805@redhat.com>
	<20110826094254.GA6520@redhat.com>
In-Reply-To: <20110826094254.GA6520@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pci: add standard bridge device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

On 08/26/2011 12:43 PM, Michael S. Tsirkin wrote:
> On Thu, Aug 18, 2011 at 08:15:43AM -0700, Avi Kivity wrote:
> >  It's correct but insufficient, the filtering code
> >  (pci_bridge_filter) needs to be updated to use the memory API.
> >
> >  Basically it gets simpler and correcter.
>
> I've been struggling with the following problem: bridges have two memory
> ranges: prefetcheable and non-prefetcheable.
>
> Memory in the device can be behind the prefetcheable and
> non-prefetcheable memory range, but things only work correctly if
> non-prefetcheable memory on the device is put behind a non-prefetcheable
> range. Prefetcheable memory can go anywhere I think.
>
> This didn't work correctly before the memory API change,
> but it was easy to fix ... Now I'm not sure how.

If it really matters, you can add a prefetchability attribute to 
MemoryRegions.  Does it though?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.