qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PULL] Memory API fixes - rom/device
Date: Sun, 28 Aug 2011 18:52:17 +0300	[thread overview]
Message-ID: <4E5A6431.5060309@redhat.com> (raw)

Anthony, please pull from

   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core

to receive fixes for the rom/device API - initialize ->ops and a new 
->opaque.

Avi Kivity (2):
       memory: fix memory_region_init_rom_device() not initializing ->ops
       memory: add opaque parameter to memory_region_init_rom_device()

  memory.c |    3 +++
  memory.h |    1 +
  2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/memory.c b/memory.c
index 8e9ac46..1491a39 100644
--- a/memory.c
+++ b/memory.c
@@ -962,11 +962,14 @@ void memory_region_init_alias(MemoryRegion *mr,

  void memory_region_init_rom_device(MemoryRegion *mr,
                                     const MemoryRegionOps *ops,
+                                   void *opaque,
                                     DeviceState *dev,
                                     const char *name,
                                     uint64_t size)
  {
      memory_region_init(mr, name, size);
+    mr->ops = ops;
+    mr->opaque = opaque;
      mr->terminates = true;
      mr->destructor = memory_region_destructor_rom_device;
      mr->ram_addr = qemu_ram_alloc(dev, name, size);
diff --git a/memory.h b/memory.h
index 0553cc7..06b83ae 100644
--- a/memory.h
+++ b/memory.h
@@ -235,6 +235,7 @@ void memory_region_init_alias(MemoryRegion *mr,
   */
  void memory_region_init_rom_device(MemoryRegion *mr,
                                     const MemoryRegionOps *ops,
+                                   void *opaque,
                                     DeviceState *dev, /* FIXME: layering violation */
                                     const char *name,
                                     uint64_t size);


-- 
error compiling committee.c: too many arguments to function

             reply	other threads:[~2011-08-28 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 15:52 Avi Kivity [this message]
2011-08-29  9:06 ` [Qemu-devel] [PULL] Memory API fixes - rom/device Avi Kivity
2011-08-29 14:52 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5A6431.5060309@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).