From: Stefan Weil <weil@mail.berlios.de>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C structures
Date: Mon, 29 Aug 2011 07:12:44 +0200 [thread overview]
Message-ID: <4E5B1FCC.5000808@mail.berlios.de> (raw)
In-Reply-To: <1D3513E3-B93D-49FC-8B36-814F4DD0FBBF@web.de>
Am 28.08.2011 22:47, schrieb Andreas Färber:
> Am 28.08.2011 um 22:43 schrieb Stefan Weil:
>
>> A packed struct needs different gcc attributes for compilations
>> with MinGW compilers because glib-2.0 adds compiler flag
>> -mms-bitfields which modifies the packing algorithm.
>
> Is that algorithm actually needed anywhere? If not, is there no GCC
> option to fix this centrally in configure for win32 only?
>
> Andreas
I think it is needed: glib-2.0 requires -mms-bitfields for MinGW which
breaks networking (and more) for w32 hosts because of changes
in struct alignment. A central solution would require removal of
-mms-bitfields or its effects. This is possible, but very risky,
because it will raise problems with glib-2.0 and w32 libraries.
Therefore a central solution was rejected.
See this thread:
http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg01877.html
Stefan
next prev parent reply other threads:[~2011-08-29 5:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 20:43 [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C structures Stefan Weil
2011-08-28 20:47 ` Andreas Färber
2011-08-29 5:12 ` Stefan Weil [this message]
2011-08-30 17:57 ` Blue Swirl
2011-08-30 18:29 ` Paolo Bonzini
2011-08-30 20:17 ` Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 2/7] block/vvfat: Fix packing for w32 Stefan Weil
2011-08-29 8:09 ` Kevin Wolf
2011-08-28 20:43 ` [Qemu-devel] [PATCH 3/7] acpi: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 4/7] hpet: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 5/7] usb: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 6/7] virtio: " Stefan Weil
2011-08-28 20:43 ` [Qemu-devel] [PATCH 7/7] slirp: " Stefan Weil
2011-08-29 10:12 ` Jan Kiszka
2011-08-29 18:22 ` Stefan Weil
2011-08-29 21:15 ` Jan Kiszka
2011-08-28 21:43 ` [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields Blue Swirl
2011-08-29 5:01 ` Stefan Weil
2011-08-29 7:19 ` Gerd Hoffmann
2011-08-29 8:34 ` TeLeMan
2011-08-29 9:39 ` Alexander Graf
2011-08-29 19:55 ` Stefan Weil
2011-08-30 7:44 ` Kevin Wolf
2011-08-30 17:25 ` Stefan Weil
2011-08-30 18:29 ` Alexander Graf
2011-08-30 19:57 ` Blue Swirl
2011-08-31 7:40 ` Kevin Wolf
2011-08-31 10:37 ` [Qemu-devel] [PATCH 0/2] Fix packing for MinGW with new macro QEMU_PACKED Stefan Weil
2011-09-03 21:12 ` Blue Swirl
2011-08-31 10:38 ` [Qemu-devel] [PATCH 1/2] Add new macro QEMU_PACKED for packed C structures Stefan Weil
2011-08-31 10:38 ` [Qemu-devel] [PATCH 2/2] Use new macro QEMU_PACKED for packed structures Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B1FCC.5000808@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).