From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxuWD-0006lw-LE
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:36:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxuWC-0002yE-LW
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:36:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29261)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxuWC-0002y8-9K
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:36:20 -0400
Message-ID: <4E5B254E.9090204@redhat.com>
Date: Mon, 29 Aug 2011 08:36:14 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1314546216-26613-1-git-send-email-avi@redhat.com>
	<20110828193342.GA7244@zapo>
In-Reply-To: <20110828193342.GA7244@zapo>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to
	memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote:
> On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote:
> >  cfi02 is annoying in that is ignores some address bits; we probably
> >  want explicit support in the memory API for that.
> >
> >  In order to get the correct opaque into the MemoryRegion object, the
> >  allocation scheme is changed so that the flash emulation code allocates
> >  memory, instead of the caller.  This clears a FIXME in the flash code.
>
> Hi Avi,
>
> Something is going wrong with the flash devices. It can be reproduced
> with the microblaze image on the wiki, you'll see the kernel complain
> with:
> pflash_write: Unimplemented flash cmd sequence (offset 00000000, wcycle 0x0 cmd 0x0 value 0xf0)
> of-flash a0000000.flash: do_map_probe() failed
>
> When it should be saying:
> a0000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank. Manufacturer ID 0x000000 Chip ID 0x000000
> Intel/Sharp Extended Query Table at 0x0031
>
>

I get exactly the same behaviour with upstream - 9f94778.  With what 
version does it work correctly?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.