From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxumO-0002Hc-5I for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:53:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QxumN-0005AC-6m for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:53:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxumM-0005A8-WA for qemu-devel@nongnu.org; Mon, 29 Aug 2011 01:53:03 -0400 Message-ID: <4E5B293A.5000706@redhat.com> Date: Mon, 29 Aug 2011 08:52:58 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314389053-30841-1-git-send-email-lmr@redhat.com> <4E581DA4.1090501@web.de> In-Reply-To: <4E581DA4.1090501@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Lucas Meneghel Rodrigues , Marcelo Tosatti , qemu-devel@nongnu.org, Gerd Hoffmann On 08/27/2011 01:26 AM, Jan Kiszka wrote: > > + > > +static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + qemu_set_irq(isa_get_irq(addr - 0x2000), !!data); > > Note that qemu-kvm retrieves (due to a hack) GSIs via isa_get_irq while > QEMU is and will remain confined to true ISA IRQs, thus provides no > access to IRQs 16-23. May break existing tests. So we likely have to > introduce a cleaner interface now if GSI is what you need here. IIRC, gsi is wanted so we can hit on unallocated gsis. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.