From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxv8L-0007Ur-VX for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qxv8L-0000N8-3O for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:15:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxv8K-0000N0-RM for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:15:45 -0400 Message-ID: <4E5B2E8C.9020006@redhat.com> Date: Mon, 29 Aug 2011 09:15:40 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314546216-26613-1-git-send-email-avi@redhat.com> <20110828203715.GB7244@zapo> <4E5B25D2.1080402@redhat.com> <20110829060022.GB3166@zapo> In-Reply-To: <20110829060022.GB3166@zapo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: qemu-devel@nongnu.org, Richard Henderson On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote: > > > > It does bite, as I saw with gdb. You can even see that from the > > qemu error - it complains about unimplemented command 0xf0, that > > comes from pflash_write() later on. > > I wasn't clear enough maybe, the code in question is running, but the > set_readble is not having any effect AFAICT. The reads, that > should come through via IO callbacks when switching mode are > not getting through. Do you ever see pflash_read beeing called? > Thanks for the clarification. I don't, and there is now a fix on git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git Please check it out. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.