From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qxw86-0006tD-Ly
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:19:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qxw85-0001Yj-8y
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:19:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qxw85-0001YY-1G
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:19:33 -0400
Message-ID: <4E5B3D79.7000006@redhat.com>
Date: Mon, 29 Aug 2011 09:19:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1314564200-6872-1-git-send-email-weil@mail.berlios.de>
	<CAAu8pHuUbXiw4rXwWE_bG2dvy=at7-MBnkWOiFhCPz9UuAx1MQ@mail.gmail.com>
	<4E5B1D42.1010605@mail.berlios.de>
In-Reply-To: <4E5B1D42.1010605@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with
	-mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Isaku Yamahata <yamahata@valinux.co.jp>, Jan Kiszka <jan.kiszka@web.de>

   Hi,

>> If a structure is only used internally by QEMU (not used in network,
>> disk or guest interfaces), changes in padding don't matter.

> [PATCH 5/7] usb: Fix packing for w32: needs packing (usb interface)

Patch looks good (and is needed as the structs are part of the guest 
interface).

cheers,
   Gerd