qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API
Date: Mon, 29 Aug 2011 10:21:03 +0300	[thread overview]
Message-ID: <4E5B3DDF.8060008@redhat.com> (raw)
In-Reply-To: <4E5B2E8C.9020006@redhat.com>

On 08/29/2011 09:15 AM, Avi Kivity wrote:
> On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote:
>> >
>> >  It does bite, as I saw with gdb.  You can even see that from the
>> >  qemu error - it complains about unimplemented command 0xf0, that
>> >  comes from pflash_write() later on.
>>
>> I wasn't clear enough maybe, the code in question is running, but the
>> set_readble is not having any effect AFAICT. The reads, that
>> should come through via IO callbacks when switching mode are
>> not getting through. Do you ever see pflash_read beeing called?
>>
>
> Thanks for the clarification.  I don't, and there is now a fix on
>
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
>

Forgot the branch:

   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git  fix-pflash

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

  parent reply	other threads:[~2011-08-29  7:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 15:43 [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API Avi Kivity
2011-08-28 18:14 ` Edgar E. Iglesias
2011-08-28 18:46   ` Edgar E. Iglesias
2011-08-29  5:35   ` Avi Kivity
2011-08-28 19:33 ` Edgar E. Iglesias
2011-08-29  5:36   ` Avi Kivity
2011-08-29  6:04     ` Edgar E. Iglesias
2011-08-29  6:13     ` Edgar E. Iglesias
2011-08-28 20:37 ` Edgar E. Iglesias
2011-08-29  5:38   ` Avi Kivity
2011-08-29  6:00     ` Edgar E. Iglesias
2011-08-29  6:15       ` Avi Kivity
2011-08-29  6:18         ` Edgar E. Iglesias
2011-08-29  7:21         ` Avi Kivity [this message]
2011-08-29  7:30           ` Edgar E. Iglesias
2011-08-29  8:15             ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5B3DDF.8060008@redhat.com \
    --to=avi@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).