From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxw9d-0007c3-9m
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:21:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxw9c-0001qs-A2
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:21:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qxw9c-0001p0-2i
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:21:08 -0400
Message-ID: <4E5B3DDF.8060008@redhat.com>
Date: Mon, 29 Aug 2011 10:21:03 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1314546216-26613-1-git-send-email-avi@redhat.com>
	<20110828203715.GB7244@zapo> <4E5B25D2.1080402@redhat.com>
	<20110829060022.GB3166@zapo> <4E5B2E8C.9020006@redhat.com>
In-Reply-To: <4E5B2E8C.9020006@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to
	memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On 08/29/2011 09:15 AM, Avi Kivity wrote:
> On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote:
>> >
>> >  It does bite, as I saw with gdb.  You can even see that from the
>> >  qemu error - it complains about unimplemented command 0xf0, that
>> >  comes from pflash_write() later on.
>>
>> I wasn't clear enough maybe, the code in question is running, but the
>> set_readble is not having any effect AFAICT. The reads, that
>> should come through via IO callbacks when switching mode are
>> not getting through. Do you ever see pflash_read beeing called?
>>
>
> Thanks for the clarification.  I don't, and there is now a fix on
>
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
>

Forgot the branch:

   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git  fix-pflash

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.