From: Avi Kivity <avi@redhat.com>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: Alexander Graf <agraf@suse.de>,
Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org,
Till Straumann <strauman@slac.stanford.edu>
Subject: Re: [Qemu-devel] [PATCH] m68k: Add uc5282 machine
Date: Mon, 29 Aug 2011 10:26:53 +0300 [thread overview]
Message-ID: <4E5B3F3D.7030709@redhat.com> (raw)
In-Reply-To: <4E270BF0.2000904@oarcorp.com>
On 07/20/2011 08:10 PM, Joel Sherrill wrote:
> From: Till Straumann <strauman@slac.stanford.edu>
>
> Add m68k machine support for Arcturus Networks
> Inc. uC5282 board. Also include
>
> a fix for the FEC ethernet controller.
>
> +static void mcf5208_resetc_init(target_phys_addr_t offset)
> +{
> + int iomemtype;
> +
> + iomemtype = cpu_register_io_memory(m5208_resetc_readfn,
> + m5208_resetc_writefn, NULL,
> + DEVICE_NATIVE_ENDIAN);
> + cpu_register_physical_memory(offset, 0x4, iomemtype);
> +}
Please use the memory api (memory.h, docs/memory.txt) rather than this.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2011-08-29 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 17:10 [Qemu-devel] [PATCH] m68k: Add uc5282 machine Joel Sherrill
2011-07-22 20:38 ` Andreas Färber
2011-07-26 12:50 ` Alexander Graf
2011-08-28 21:34 ` Andreas Färber
2011-08-29 6:53 ` Alexander Graf
2011-08-29 7:26 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B3F3D.7030709@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=joel.sherrill@oarcorp.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=strauman@slac.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).