From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxwFQ-0000n1-Ua
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:27:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxwFP-0002la-F6
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:27:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65405)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxwFP-0002lW-5y
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 03:27:07 -0400
Message-ID: <4E5B3F3D.7030709@redhat.com>
Date: Mon, 29 Aug 2011 10:26:53 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E270BF0.2000904@oarcorp.com>
In-Reply-To: <4E270BF0.2000904@oarcorp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] m68k: Add uc5282 machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: Alexander Graf <agraf@suse.de>, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org, Till Straumann <strauman@slac.stanford.edu>

On 07/20/2011 08:10 PM, Joel Sherrill wrote:
> From: Till Straumann <strauman@slac.stanford.edu>
>
> Add m68k machine support for Arcturus Networks
> Inc. uC5282 board.  Also include
>
> a fix for the FEC ethernet controller.
>
> +static void mcf5208_resetc_init(target_phys_addr_t offset)
> +{
> +    int iomemtype;
> +
> +    iomemtype = cpu_register_io_memory(m5208_resetc_readfn,
> +                                       m5208_resetc_writefn, NULL,
> +                                       DEVICE_NATIVE_ENDIAN);
> +    cpu_register_physical_memory(offset, 0x4, iomemtype);
> +}

Please use the memory api (memory.h, docs/memory.txt) rather than this.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.