From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxzIV-0003Jf-Gu for qemu-devel@nongnu.org; Mon, 29 Aug 2011 06:42:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QxzIU-0001Jy-O6 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 06:42:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxzIU-0001Ju-Ft for qemu-devel@nongnu.org; Mon, 29 Aug 2011 06:42:30 -0400 Message-ID: <4E5B6DC7.3090903@redhat.com> Date: Mon, 29 Aug 2011 12:45:27 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1314073663-32691-1-git-send-email-devin122@gmail.com> <1314073663-32691-3-git-send-email-devin122@gmail.com> In-Reply-To: <1314073663-32691-3-git-send-email-devin122@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 2/7] block: make bdrv_open_common more ready to be called by bdrv_open_conversion_target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Devin Nakamura Cc: qemu-devel@nongnu.org Am 23.08.2011 06:27, schrieb Devin Nakamura: > Signed-off-by: Devin Nakamura > --- > block.c | 18 ++++++++++++------ > 1 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/block.c b/block.c > index a8a013a..ac5a103 100644 > --- a/block.c > +++ b/block.c > @@ -441,14 +441,17 @@ static int refresh_total_sectors(BlockDriverState *bs, int64_t hint) > * Common part for opening disk images and files > */ > static int bdrv_open_common(BlockDriverState *bs, const char *filename, > - int flags, BlockDriver *drv) > + int flags, BlockDriver *drv, BlockConversionOptions *drv_options, > + QEMUOptionParameter *usr_options, bool force) > { > int ret, open_flags; > > assert(drv != NULL); > > - bs->file = NULL; > - bs->total_sectors = 0; > + if (~flags & BDRV_O_CONVERSION) { I prefer if ((flags & BDRV_O_CONVERSION) == 0), but that's a matter of taste I guess. > + bs->file = NULL; > + bs->total_sectors = 0; > + } Why are these a problem from BDRV_O_CONVERSION? (Reading the rest of the patch, I understand bs->file, but still not bs->total_sectors) Maybe add a comment. Kevin