Re: [Qemu-devel] [PATCH V4 0/7] Block Conversion

[Kevin Wolf <kwolf@redhat.com>]

Am 23.08.2011 06:27, schrieb Devin Nakamura:
> This patch series introduces the api to support block conversion.
> 
> Devin Nakamura (7):
>   block: add block conversion api
>   block: make bdrv_open_common more ready to be called by
>     bdrv_open_conversion_target
>   block: add bdrv_get_conversion_options()
>   block: add bdrv_open_conversion_target()
>   block: add bdrv_get_mapping()
>   block: add bdrv_map()
>   block: add bdrv_copy_header()
> 
>  block.c     |  127 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  block.h     |   16 +++++++
>  block_int.h |   82 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 219 insertions(+), 6 deletions(-)

Looks good to me apart from the minor comments on patches 1 and 2.

We can't merge interfaces into master without having users, though. So
as the interface itself seems to be final now, please continue with
posting the patches implementing this interface. (You can just include
more patches in a v5, or send a second patch series and add a note in
PATCH 0/n that it depends on this one)

Kevin