From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxzlK-0003ml-1O
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 07:12:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxzlI-000628-Lf
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 07:12:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QxzlI-00061x-E2
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 07:12:16 -0400
Message-ID: <4E5B73F8.2040602@redhat.com>
Date: Mon, 29 Aug 2011 14:11:52 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4B17C12B.4020300@linux.vnet.ibm.com> <4B17CC5F.20101@redhat.com>
	<CA+tHM2HH437Y4KLmGO+59wvR-TMSacGnxgt5QB8w5LDtJ+p3Xw@mail.gmail.com>
	<4E59F15E.6000201@redhat.com>
	<F2AA4282-91FD-493A-9337-AB4922C2925A@suse.de>
	<4E5AA849.5090400@web.de> <20110828221437.GA27777@morn.localdomain>
	<4E5B2450.3050209@redhat.com> <4E5B691C.9050507@siemens.com>
	<4E5B7168.5070306@redhat.com> <4E5B7262.4010902@siemens.com>
In-Reply-To: <4E5B7262.4010902@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] HPET configuration in Seabios
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andrew Theurer <habanero@linux.vnet.ibm.com>, Gleb Natapov <gleb@redhat.com>, "kvm@vger.kernel.org list" <kvm@vger.kernel.org>, seabios <seabios@seabios.org>, ya su <suya94335@gmail.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Kevin O'Connor <kevin@koconnor.net>

On 08/29/2011 02:05 PM, Jan Kiszka wrote:
> On 2011-08-29 13:00, Avi Kivity wrote:
> >  On 08/29/2011 01:25 PM, Jan Kiszka wrote:
> >>>
> >>>   Can't seabios just poke at the hpet itself and see if it exists or not?
> >>>
> >>
> >>  Would be hard for the BIOS to guess the locations of the blocks unless
> >>  we define the addresses used by QEMU as something like base + hpet_no *
> >>  block_size in all cases.
> >>
> >
> >  Currently we have a fixed address.  We could do:
> >
> >    if available in fw_cfg:
> >        use that (may indicate no hpet)
> >    elif fixed address works:
> >        use that
> >    else
> >        no hpet
>
> Currently, we also only have a single HPET block, but that's just
> because of some QEMU limitations that will vanish sooner or later. Then
> nothing will prevent multiple "-device hpet,base=XXX".
>

Yes, so we should enable the fw_cfg interface before that happens.


-- 
error compiling committee.c: too many arguments to function