From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy2Dt-00074F-9v for qemu-devel@nongnu.org; Mon, 29 Aug 2011 09:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy2Ds-0005eG-7l for qemu-devel@nongnu.org; Mon, 29 Aug 2011 09:49:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy2Dr-0005dz-UM for qemu-devel@nongnu.org; Mon, 29 Aug 2011 09:49:56 -0400 Message-ID: <4E5B9901.8010201@redhat.com> Date: Mon, 29 Aug 2011 09:49:53 -0400 From: Umesh Deshpande MIME-Version: 1.0 References: <893c5f1f472e252d9ae43a8348e0e0ef882936ce.1314466743.git.udeshpan@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] Separate migration thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/29/2011 05:09 AM, Stefan Hajnoczi wrote: > On Sat, Aug 27, 2011 at 7:09 PM, Umesh Deshpande wrote: >> This patch creates a separate thread for the guest migration on the source side. >> All exits (on completion/error) from the migration thread are handled by a >> bottom handler, which is called from the iothread. >> >> Signed-off-by: Umesh Deshpande >> --- >> buffered_file.c | 76 ++++++++++++++++++++---------------- >> migration.c | 105 ++++++++++++++++++++++++++++++-------------------- >> migration.h | 8 ++++ >> qemu-thread-posix.c | 10 +++++ >> qemu-thread.h | 1 + > Will this patch break Windows builds by adding a function to > qemu-thread-posix.c which is not implemented in qemu-thread-win32.c? Yes, equivalent function needs to be added in qemu-thread.win32.c