From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy6U9-00081v-Ky
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:23:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy6U8-0003Qu-Hw
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:23:01 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:51042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy6U8-0003Qq-9j
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:23:00 -0400
Message-ID: <4E5BD900.3020709@mail.berlios.de>
Date: Mon, 29 Aug 2011 20:22:56 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1314564200-6872-1-git-send-email-weil@mail.berlios.de>
	<1314564200-6872-8-git-send-email-weil@mail.berlios.de>
	<4E5B660F.1020607@siemens.com>
In-Reply-To: <4E5B660F.1020607@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/7] slirp: Fix packing for w32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 29.08.2011 12:12, schrieb Jan Kiszka:
> On 2011-08-28 22:43, Stefan Weil wrote:
>> Use QEMU_PACKED to eliminate the effects of compiler option
>> -mms-bitfields.
>>
>> Cc: Jan Kiszka<jan.kiszka@siemens.com>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>> ---
>>   slirp/slirp.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/slirp/slirp.h b/slirp/slirp.h
>> index dcf99d5..28a5c03 100644
>> --- a/slirp/slirp.h
>> +++ b/slirp/slirp.h
>> @@ -199,7 +199,7 @@ struct arphdr {
>>       uint32_t      ar_sip;           /* sender IP address       */
>>       unsigned char ar_tha[ETH_ALEN]; /* target hardware address */
>>       uint32_t      ar_tip;           /* target IP address       */
>> -} __attribute__((packed));
>> +} QEMU_PACKED;
>>
>>   #define ARP_TABLE_SIZE 16
>>
>
> There are further cases in slirp. Please address them as well.
>
> Jan

I only addressed those cases which are affected by -mms-bitfields, see
http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03428.html.

Other files with __attribute__((packed)) will be handled in separate 
patches.

I don't think that I missed a case which breaks slirp, but if I did,
just tell me the struct name so I can fix it, too.

Stefan