From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy7Nl-0003zZ-7G
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:20:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy7Nj-00065W-VO
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:20:29 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:53172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qy7Nj-00065K-Qn
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:20:27 -0400
Message-ID: <4E5BE678.702@mail.berlios.de>
Date: Mon, 29 Aug 2011 21:20:24 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1314640005-4278-1-git-send-email-weil@mail.berlios.de>
	<87fwkk6pca.fsf@ginnungagap.bsc.es>
In-Reply-To: <87fwkk6pca.fsf@ginnungagap.bsc.es>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Fix linux build with trace backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: xscript@gmx.net
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 29.08.2011 20:32, schrieb Llu=EDs:
> Stefan Weil writes:
>> Builds with configure --enable-trace-backend=3Dsimple failed on linux
>> because qemu-ga then uses simpletrace.c which needs get_clock which
>> needs use_rt_clock which was unresolved.
>> Adding qemu-timer-common.o fixes this. It adds a little overhead
>> (about 150 byte).
>
> There are a couple of threads associated to this very same topic:
>
> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02915.html
> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03302.html
>
> Lluis

Thanks for the links. So we now have three patch sets for one problem,
and it will be fixed by a maintainer commit soon :-)

I personally prefer Blue Swirl's patch (which avoids the overhead)
or my own patch (which adds a little overhead but is the simplest
of all three patches). Sorting lists of object files and removing
duplicates looks strange in my opinion (and might also be bad when
related code no longer shares the same memory page).

With my patch, qemu-ga and the other tools (qemu-io, qemu-img, ...)
also use similar object lists.

Kind regards,
Stefan