From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy7af-0002cg-01 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:33:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy7ad-0000IJ-H2 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:33:48 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:56335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy7ad-0000IF-EV for qemu-devel@nongnu.org; Mon, 29 Aug 2011 15:33:47 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7TJ9Cxw008793 for ; Mon, 29 Aug 2011 15:09:12 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7TJXkku270898 for ; Mon, 29 Aug 2011 15:33:46 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7TJXkqC015537 for ; Mon, 29 Aug 2011 15:33:46 -0400 Message-ID: <4E5BE999.9050509@linux.vnet.ibm.com> Date: Mon, 29 Aug 2011 14:33:45 -0500 From: Michael Roth MIME-Version: 1.0 References: <1314640005-4278-1-git-send-email-weil@mail.berlios.de> <87fwkk6pca.fsf@ginnungagap.bsc.es> <4E5BE678.702@mail.berlios.de> In-Reply-To: <4E5BE678.702@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Fix linux build with trace backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , Anthony Liguori , xscript@gmx.net, QEMU Developers On 08/29/2011 02:20 PM, Stefan Weil wrote: > Am 29.08.2011 20:32, schrieb Llu=EDs: >> Stefan Weil writes: >>> Builds with configure --enable-trace-backend=3Dsimple failed on linux >>> because qemu-ga then uses simpletrace.c which needs get_clock which >>> needs use_rt_clock which was unresolved. >>> Adding qemu-timer-common.o fixes this. It adds a little overhead >>> (about 150 byte). >> >> There are a couple of threads associated to this very same topic: >> >> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02915.html >> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03302.html >> >> Lluis > > Thanks for the links. So we now have three patch sets for one problem, > and it will be fixed by a maintainer commit soon :-) > 4, actually :) An alternative proposal from Blue was setting=20 CONFIG_QEMU_TIMER based on whether or not qemu-timer-common.o was needed=20 for a particular dependency, so anyone dependent on, say, trace-obj-y=20 could just have: blah-obj-$(CONFIG_QEMU_TIMER) +=3D qemu-timer-common.o I CC'd you on the patch. > I personally prefer Blue Swirl's patch (which avoids the overhead) > or my own patch (which adds a little overhead but is the simplest > of all three patches). Sorting lists of object files and removing > duplicates looks strange in my opinion (and might also be bad when > related code no longer shares the same memory page). > I actually preferred the sorted list approach, I think it mirrors how=20 most projects handle duplicate header includes and allows for defining a=20 self-sufficient group of objects without needed to worry whether 2=20 groups list the same object as a dependency. This allows results in one=20 group being underspecified and any subsequent user of that group to be=20 aware of what's missing. > With my patch, qemu-ga and the other tools (qemu-io, qemu-img, ...) > also use similar object lists. > > Kind regards, > Stefan > > >