From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path
Date: Mon, 29 Aug 2011 23:18:26 +0200 [thread overview]
Message-ID: <4E5C0222.8040607@web.de> (raw)
In-Reply-To: <4E5C00F0.9070103@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On 2011-08-29 23:13, Avi Kivity wrote:
> On 08/30/2011 12:06 AM, Jan Kiszka wrote:
>> >
>> > Does this need to be save/restored for migration?
>>
>> Nope, but we need some other measure. I thought to remember the pic was
>> refreshing this after load, but I do not find any traces of this now. We
>> likely need a post_load handler in the i8259 that re-asserts the IRQ as
>> required.
>>
>
> We need some kind of two phase restore. In the first phase all state is
> restored; since some of that state drivers outputs that are input to
> other devices, they may experience an edge, and we need to supress
> that. In the second phase edge detection is unsupressed and the device
> goes live.
Sounds like it's time to open cpu_synchronize_all_post_init for non-kvm
folks.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-08-29 21:18 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 14:16 [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path Jan Kiszka
2011-08-28 7:10 ` Blue Swirl
2011-08-28 9:08 ` Jan Kiszka
2011-08-29 19:25 ` Anthony Liguori
2011-08-29 21:06 ` Jan Kiszka
2011-08-29 21:13 ` Avi Kivity
2011-08-29 21:18 ` Jan Kiszka [this message]
2011-08-30 19:19 ` Blue Swirl
2011-08-30 19:28 ` Jan Kiszka
2011-08-30 19:43 ` Blue Swirl
2011-08-31 8:25 ` Peter Maydell
2011-08-31 10:53 ` Jan Kiszka
2011-08-31 17:41 ` Blue Swirl
2011-08-31 18:17 ` Jan Kiszka
2011-08-31 19:44 ` Blue Swirl
2011-09-04 10:33 ` Blue Swirl
2011-09-04 12:25 ` Gleb Natapov
2011-09-03 19:54 ` Anthony Liguori
2011-09-04 12:13 ` Jan Kiszka
2011-09-04 13:32 ` Anthony Liguori
2011-09-04 13:36 ` Jan Kiszka
2011-09-04 13:41 ` Anthony Liguori
2011-09-04 13:49 ` Jan Kiszka
2011-09-04 13:57 ` Anthony Liguori
2011-09-04 14:37 ` Anthony Liguori
2011-09-04 15:20 ` Blue Swirl
2011-09-04 15:31 ` Anthony Liguori
2011-09-04 15:44 ` Blue Swirl
2011-09-05 10:44 ` Edgar E. Iglesias
2011-09-04 14:12 ` Avi Kivity
2011-09-04 14:43 ` Anthony Liguori
2011-09-04 15:03 ` Avi Kivity
2011-09-04 15:19 ` Anthony Liguori
2011-09-04 15:34 ` Avi Kivity
2011-09-04 15:27 ` Blue Swirl
2011-09-04 12:17 ` Avi Kivity
2011-09-04 12:37 ` Jan Kiszka
2011-09-04 12:43 ` Avi Kivity
2011-09-04 13:38 ` Anthony Liguori
2011-09-04 13:42 ` Jan Kiszka
2011-09-04 13:55 ` Anthony Liguori
2011-09-04 13:35 ` Anthony Liguori
2011-08-31 8:28 ` Avi Kivity
2011-08-31 16:59 ` Blue Swirl
2011-08-31 18:04 ` Edgar E. Iglesias
2011-08-31 18:28 ` Jan Kiszka
2011-09-01 5:58 ` Avi Kivity
2011-09-03 20:07 ` Anthony Liguori
2011-09-03 21:10 ` Blue Swirl
2011-09-03 21:41 ` Anthony Liguori
2011-09-04 9:27 ` Blue Swirl
2011-09-03 19:53 ` Anthony Liguori
2011-09-03 21:01 ` Blue Swirl
2011-09-04 14:49 ` Anthony Liguori
2011-09-05 8:38 ` Edgar E. Iglesias
2011-09-05 8:51 ` Avi Kivity
2011-09-05 9:02 ` Peter Maydell
2011-09-05 9:14 ` Avi Kivity
2011-09-05 9:22 ` Edgar E. Iglesias
2011-09-05 9:28 ` Avi Kivity
2011-09-05 10:47 ` Edgar E. Iglesias
2011-09-05 19:36 ` Blue Swirl
2011-09-06 7:46 ` Avi Kivity
2011-09-01 9:08 ` [Qemu-devel] [PATCH v2] pc: Fix and clean " Jan Kiszka
2011-09-03 8:58 ` Blue Swirl
2011-09-03 11:17 ` Jan Kiszka
2011-09-03 11:37 ` Blue Swirl
2011-09-03 18:14 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5C0222.8040607@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=lmr@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).