From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: Fix memory_region_get_ram_ptr for ROM devices
Date: Tue, 30 Aug 2011 11:21:39 +0300 [thread overview]
Message-ID: <4E5C9D93.7000806@redhat.com> (raw)
In-Reply-To: <4E5C14E0.9060800@web.de>
On 08/30/2011 01:38 AM, Jan Kiszka wrote:
> On 2011-08-29 23:15, Avi Kivity wrote:
> > On 08/29/2011 10:14 PM, Anthony Liguori wrote:
> >>> OK, that was simple: It's still "pflash_cfi01/pflash_cfi02: convert to
> >>> memory API".
> >>
> >>
> >> Hrm, okay. Avi, maybe drop that patch and submit a v3?
> >>
> >
> > Of course. I'm sta^Wcontinuing to hate that pflash thing.
>
> It's not always the pflash... :)
I'm willing to hate rom_device equally. There's enough to go round.
> ---8<---
>
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Mask out the sub-page bits that are used by ROM device for storing the
> io-index and the IO_MEM_ROMD flag.
Applied; thanks for the help. With this, everything works, yes?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-30 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 15:34 [Qemu-devel] [PULL][v2] Memory API conversions, batch 5 Avi Kivity
2011-08-29 15:42 ` Anthony Liguori
2011-08-29 15:44 ` Avi Kivity
2011-08-29 16:17 ` Jan Kiszka
2011-08-29 16:22 ` Jan Kiszka
2011-08-29 19:14 ` Anthony Liguori
2011-08-29 19:14 ` Anthony Liguori
2011-08-29 21:15 ` Avi Kivity
2011-08-29 22:38 ` [Qemu-devel] [PATCH] memory: Fix memory_region_get_ram_ptr for ROM devices Jan Kiszka
2011-08-30 8:21 ` Avi Kivity [this message]
2011-08-30 11:26 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5C9D93.7000806@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).