From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QyT41-0006Gc-Tq
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 14:29:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QyT40-0004Q1-Vx
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 14:29:33 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:55554)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QyT40-0004PQ-Qs
	for qemu-devel@nongnu.org; Tue, 30 Aug 2011 14:29:32 -0400
Received: by wwf25 with SMTP id 25so6720516wwf.10
	for <qemu-devel@nongnu.org>; Tue, 30 Aug 2011 11:29:31 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E5D2BFC.2090401@redhat.com>
Date: Tue, 30 Aug 2011 20:29:16 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1314564200-6872-1-git-send-email-weil@mail.berlios.de>
	<1314564200-6872-2-git-send-email-weil@mail.berlios.de>
	<CAAu8pHu9nPQdaENGpmJaVPZDp-tk58Zcg_52z7jhAr4YkJtYiw@mail.gmail.com>
In-Reply-To: <CAAu8pHu9nPQdaENGpmJaVPZDp-tk58Zcg_52z7jhAr4YkJtYiw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/7] Add new macro QEMU_PACKED for packed C
	structures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 08/30/2011 07:57 PM, Blue Swirl wrote:
>> >
>> >  +#if defined(_WIN32)
>> >  +# define QEMU_PACKED __attribute__((gcc_struct, packed))
> Maybe we could also use gcc_struct also for non-win32?
>
>> >  +#else
>> >  +# define QEMU_PACKED __attribute__((packed))
>> >  +#endif

Indeed.

Paolo