From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyjf0-0006BI-LX for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyjez-0003Uy-QH for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:12:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyjez-0003Um-Hw for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:12:49 -0400 Message-ID: <4E5E2530.7030309@redhat.com> Date: Wed, 31 Aug 2011 14:12:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1314778850-13637-1-git-send-email-yhalperi@redhat.com> <4E5E0BB8.4060809@redhat.com> <4E5E1869.2060503@redhat.com> In-Reply-To: <4E5E1869.2060503@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: alevy@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org Hi, >> You can call qxl_set_irq unconditionally, >> it checks for int_pending anyway. > Hi, > qxl_set_irq doesn't test int_pending, but it will call qemu_set_irq with > level=0 if !int_pending. Yes. Also checks int_mask. That is fine, isn't it? BTW: qxl_update_irq would be a better name, this is what it actually does: update irq line state from device state. cheers, Gerd