From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk8L-0005dS-S4 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:43:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyk8K-0001X1-P2 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:43:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk8K-0001Wv-IB for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:43:08 -0400 Message-ID: <4E5E2C4E.30907@redhat.com> Date: Wed, 31 Aug 2011 14:42:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1314794254-11624-1-git-send-email-yhalperi@redhat.com> In-Reply-To: <1314794254-11624-1-git-send-email-yhalperi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: alevy@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org On 08/31/11 14:37, Yonit Halperin wrote: > if qxl_send_events was called from spice server context, and then > migration had completed before a call to pipe_read, the target > guest qxl driver didn't get the interrupt. In addition, > qxl_send_events ignored further interrupts of the same kind, since > ram->int_pending was set. As a result, the guest driver was stacked > or very slow (when the waiting for the interrupt was with timeout). Looks fine except for this: === checkpatch complains === WARNING: line over 80 characters #22: FILE: hw/qxl.c:1468: + * migration ended, qxl_set_irq for these events might not have been called cheers, Gerd PS: /me suggests to check out http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html