From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QyksX-0004Fu-OU
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:30:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QyksW-0001QK-RJ
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:30:53 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:40759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QyksW-0001Q2-EN
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:30:52 -0400
Received: by yih10 with SMTP id 10so629284yih.4
	for <qemu-devel@nongnu.org>; Wed, 31 Aug 2011 06:30:51 -0700 (PDT)
Message-ID: <4E5E3789.3010603@codemonkey.ws>
Date: Wed, 31 Aug 2011 08:30:49 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com>	<4E5D8BAA.9010302@codemonkey.ws>	<alpine.LNX.2.00.1108310527290.3538@linmac>	<4E5D9570.1030201@codemonkey.ws>
	<alpine.LNX.2.00.1108311716530.1522@linmac>
In-Reply-To: <alpine.LNX.2.00.1108311716530.1522@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, bifferos <bifferos@yahoo.co.uk>

On 08/31/2011 08:17 AM, malc wrote:
> On Tue, 30 Aug 2011, Anthony Liguori wrote:
>
>> On 08/30/2011 08:30 PM, malc wrote:
>>> On Tue, 30 Aug 2011, Anthony Liguori wrote:
>>>
>>>> This won't even come close to passing checkpatch.pl
>>>
>>> Have you actually tried?
>>
>> Sigh.  I was hoping checkpatch.pl was more useful than it appears to be.
>>
>> At any rate, the patch doesn't follow CODING_STYLE.
>>
>
> Where?

3. Naming

Variables are lower_case_with_underscores; easy to type and read. 
Structured
type names are in CamelCase; harder to type but standing out.  Scalar type
names are lower_case_with_underscores_ending_with_a_t, like the POSIX
uint64_t and family.  Note that this last convention contradicts POSIX
and is therefore likely to be changed.

When wrapping standard library functions, use the prefix qemu_ to alert
readers that they are seeing a wrapped version; otherwise avoid this prefix.

Regards,

Anthony Liguori


> [..snip..]
>