From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyl2C-0007kR-PN for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:40:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyl2B-0003Ez-K4 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:40:52 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:39418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyl2B-0003Ev-EG for qemu-devel@nongnu.org; Wed, 31 Aug 2011 09:40:51 -0400 Received: by gyd12 with SMTP id 12so605423gyd.4 for ; Wed, 31 Aug 2011 06:40:50 -0700 (PDT) Message-ID: <4E5E39DF.3080609@codemonkey.ws> Date: Wed, 31 Aug 2011 08:40:47 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, bifferos On 08/31/2011 08:39 AM, malc wrote: > On Wed, 31 Aug 2011, Anthony Liguori wrote: > >> On 08/31/2011 08:17 AM, malc wrote: >>> On Tue, 30 Aug 2011, Anthony Liguori wrote: >>> >>>> On 08/30/2011 08:30 PM, malc wrote: >>>>> On Tue, 30 Aug 2011, Anthony Liguori wrote: >>>>> >>>>>> This won't even come close to passing checkpatch.pl >>>>> >>>>> Have you actually tried? >>>> >>>> Sigh. I was hoping checkpatch.pl was more useful than it appears to be. >>>> >>>> At any rate, the patch doesn't follow CODING_STYLE. >>>> >>> >>> Where? >> >> 3. Naming >> >> Variables are lower_case_with_underscores; easy to type and read. Structured >> type names are in CamelCase; harder to type but standing out. Scalar type >> names are lower_case_with_underscores_ending_with_a_t, like the POSIX >> uint64_t and family. Note that this last convention contradicts POSIX >> and is therefore likely to be changed. > > Where in the patch this was violated, and do note that fields are not > variables. fields are variables. And the struct names weren't all CamelCase. Regards, Anthony Liguori > >> >> When wrapping standard library functions, use the prefix qemu_ to alert >> readers that they are seeing a wrapped version; otherwise avoid this prefix. > > And what ^^^ has to do with anything? > >> >> Regards, >> >> Anthony Liguori >> >> >>> [..snip..] >>> >> >