Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

[Anthony Liguori <anthony@codemonkey.ws>]

On 08/31/2011 08:51 AM, malc wrote:
> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>
>> On 08/31/2011 08:39 AM, malc wrote:
>>> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>>>
>>>> On 08/31/2011 08:17 AM, malc wrote:
>>>>> On Tue, 30 Aug 2011, Anthony Liguori wrote:
>>>>>
>>>>>> On 08/30/2011 08:30 PM, malc wrote:
>>>>>>> On Tue, 30 Aug 2011, Anthony Liguori wrote:
>>>>>>>
>>>>>>>> This won't even come close to passing checkpatch.pl
>>>>>>>
>>>>>>> Have you actually tried?
>>>>>>
>>>>>> Sigh.  I was hoping checkpatch.pl was more useful than it appears to
>>>>>> be.
>>>>>>
>>>>>> At any rate, the patch doesn't follow CODING_STYLE.
>>>>>>
>>>>>
>>>>> Where?
>>>>
>>>> 3. Naming
>>>>
>>>> Variables are lower_case_with_underscores; easy to type and read.
>>>> Structured
>>>> type names are in CamelCase; harder to type but standing out.  Scalar type
>>>> names are lower_case_with_underscores_ending_with_a_t, like the POSIX
>>>> uint64_t and family.  Note that this last convention contradicts POSIX
>>>> and is therefore likely to be changed.
>>>
>>> Where in the patch this was violated, and do note that fields are not
>>> variables.
>>
>> fields are variables.  And the struct names weren't all CamelCase.
>
> c&v please. The only thing i can agree with is descriptor_t other than
> that patch is just fine.

Upper case field names are not okay.  If you think coding style isn't 
clear, that's a bug in coding style.

Just look at the vast majority of code in the tree.

Regards,

Anthony Liguori

>
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>>
>>>>
>>>> When wrapping standard library functions, use the prefix qemu_ to alert
>>>> readers that they are seeing a wrapped version; otherwise avoid this
>>>> prefix.
>>>
>>> And what ^^^ has to do with anything?
>>>
>>>>
>>>> Regards,
>>>>
>>>> Anthony Liguori
>>>>
>>>>
>>>>> [..snip..]
>>>>>
>>>>
>>>
>>
>