From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QylnB-0001F8-4u for qemu-devel@nongnu.org; Wed, 31 Aug 2011 10:29:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyln9-0005BE-UF for qemu-devel@nongnu.org; Wed, 31 Aug 2011 10:29:25 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:46117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyln9-0005Aq-Q3 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 10:29:23 -0400 Received: by gyd12 with SMTP id 12so651687gyd.4 for ; Wed, 31 Aug 2011 07:29:22 -0700 (PDT) Message-ID: <4E5E4540.5030408@codemonkey.ws> Date: Wed, 31 Aug 2011 09:29:20 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, bifferos On 08/31/2011 08:51 AM, malc wrote: > On Wed, 31 Aug 2011, Anthony Liguori wrote: > >> On 08/31/2011 08:39 AM, malc wrote: >>> On Wed, 31 Aug 2011, Anthony Liguori wrote: >>> >>>> On 08/31/2011 08:17 AM, malc wrote: >>>>> On Tue, 30 Aug 2011, Anthony Liguori wrote: >>>>> >>>>>> On 08/30/2011 08:30 PM, malc wrote: >>>>>>> On Tue, 30 Aug 2011, Anthony Liguori wrote: >>>>>>> >>>>>>>> This won't even come close to passing checkpatch.pl >>>>>>> >>>>>>> Have you actually tried? >>>>>> >>>>>> Sigh. I was hoping checkpatch.pl was more useful than it appears to >>>>>> be. >>>>>> >>>>>> At any rate, the patch doesn't follow CODING_STYLE. >>>>>> >>>>> >>>>> Where? >>>> >>>> 3. Naming >>>> >>>> Variables are lower_case_with_underscores; easy to type and read. >>>> Structured >>>> type names are in CamelCase; harder to type but standing out. Scalar type >>>> names are lower_case_with_underscores_ending_with_a_t, like the POSIX >>>> uint64_t and family. Note that this last convention contradicts POSIX >>>> and is therefore likely to be changed. >>> >>> Where in the patch this was violated, and do note that fields are not >>> variables. >> >> fields are variables. And the struct names weren't all CamelCase. > > c&v please. The only thing i can agree with is descriptor_t other than > that patch is just fine. Upper case field names are not okay. If you think coding style isn't clear, that's a bug in coding style. Just look at the vast majority of code in the tree. Regards, Anthony Liguori > >> >> Regards, >> >> Anthony Liguori >> >>> >>>> >>>> When wrapping standard library functions, use the prefix qemu_ to alert >>>> readers that they are seeing a wrapped version; otherwise avoid this >>>> prefix. >>> >>> And what ^^^ has to do with anything? >>> >>>> >>>> Regards, >>>> >>>> Anthony Liguori >>>> >>>> >>>>> [..snip..] >>>>> >>>> >>> >> >