From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynvS-0006jG-Ic for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QynvR-0007Fd-EX for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:46:06 -0400 Received: from thoth.sbs.de ([192.35.17.2]:26221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynvR-0007FW-4G for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:46:05 -0400 Message-ID: <4E5E6542.1020104@siemens.com> Date: Wed, 31 Aug 2011 18:45:54 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E5BB532.4010106@siemens.com> <20110830003545.GA17142@morn.localdomain> In-Reply-To: <20110830003545.GA17142@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Probe HPET existence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Andrew Theurer , Gleb Natapov , seabios , ya su , Alexander Graf , qemu-devel , Avi Kivity On 2011-08-30 02:35, Kevin O'Connor wrote: > On Mon, Aug 29, 2011 at 05:50:10PM +0200, Jan Kiszka wrote: >> QEMU does not provide a HPET block if it was configured with -no-hpet, >> other machines SeaBIOS runs on may lack a HPET as well. Perform basic >> checks the ID register for a reasonable vendor ID and a clock period >> within the valid range, do not build the HPET table if that fails. > > It looks okay to me. > > BTW, any particular reason to use 0x05F5E100 instead of 100000000? No, I just blindly grabbed the first number I found in the spec. You may change if you like on commit. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux