From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz0ET-00016r-GH for qemu-devel@nongnu.org; Thu, 01 Sep 2011 01:54:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qz0ES-0005xw-Gj for qemu-devel@nongnu.org; Thu, 01 Sep 2011 01:54:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz0ES-0005xF-5F for qemu-devel@nongnu.org; Thu, 01 Sep 2011 01:54:32 -0400 Message-ID: <4E5F1E14.3060606@redhat.com> Date: Thu, 01 Sep 2011 08:54:28 +0300 From: Avi Kivity MIME-Version: 1.0 References: <201109010054.53424.michael@walle.cc> In-Reply-To: <201109010054.53424.michael@walle.cc> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] new memory api: offsets? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Walle Cc: qemu-devel@nongnu.org On 09/01/2011 01:54 AM, Michael Walle wrote: > Hi Avi, > > while debugging, i noticed, that mr->offset is never set, expect in the > initializer. (The subregion collision warning is printed although the regions > are not overlapping.) Is this intended? Did you miss memory_region_set_offset()? The subregion collision warning is unrelated? > btw. you may include the memory region name in the warning. > sure, patches welcome. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.