From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, bifferos <bifferos@yahoo.co.uk>
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
Date: Thu, 01 Sep 2011 12:42:55 +0200 [thread overview]
Message-ID: <4E5F61AF.7040308@redhat.com> (raw)
In-Reply-To: <4E5E5BF3.50801@codemonkey.ws>
On 08/31/11 18:06, Anthony Liguori wrote:
> On 08/31/2011 09:35 AM, malc wrote:
>> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>>
>>> Upper case field names are not okay. If you think coding style isn't
>>> clear,
>>> that's a bug in coding style.
> There's no benefit to going through and changing existing code but new
> code needs to be consistent with the vast majority of code in the rest
> of the tree. It's about overall code base consistency and maintainability.
I don't see the point in being too picky about this. Especially
consistency is a tricky thing.
As USB has been raised in this thread already: The struct field names
in the USBDesc* structs are actually consistent. They are consistent
with the naming convention in the USB world, i.e. you'll find those
funky names like "wMaxPacketSize" in the USB specs, in the "lsusb -v"
output and probably other places too. Which makes alot of sense IMHO
and is quite convenient when hacking the USB code.
The USB naming convention and the qemu naming convention don't match, so
it is impossible to please everybody here ...
cheers,
Gerd
next prev parent reply other threads:[~2011-09-01 10:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 1:05 [Qemu-devel] [PATCH] Add support for r6040 NIC bifferos
2011-08-31 1:17 ` Anthony Liguori
2011-08-31 1:30 ` malc
2011-08-31 1:59 ` Anthony Liguori
2011-08-31 13:17 ` malc
2011-08-31 13:30 ` Anthony Liguori
2011-08-31 13:39 ` malc
2011-08-31 13:40 ` Anthony Liguori
2011-08-31 13:51 ` malc
2011-08-31 14:29 ` Anthony Liguori
2011-08-31 14:35 ` malc
2011-08-31 16:06 ` Anthony Liguori
2011-08-31 16:24 ` malc
2011-08-31 18:35 ` Blue Swirl
2011-08-31 18:37 ` malc
2011-08-31 17:59 ` Edgar E. Iglesias
2011-08-31 18:46 ` Blue Swirl
2011-08-31 18:58 ` Edgar E. Iglesias
2011-08-31 18:48 ` Anthony Liguori
2011-08-31 19:12 ` Edgar E. Iglesias
2011-08-31 19:18 ` Edgar E. Iglesias
2011-08-31 19:23 ` Anthony Liguori
2011-08-31 19:52 ` Blue Swirl
2011-08-31 18:30 ` Blue Swirl
2011-08-31 21:23 ` bifferos
2011-09-01 7:39 ` Markus Armbruster
2011-09-01 21:49 ` Anthony Liguori
2011-09-03 9:44 ` Blue Swirl
2011-09-01 10:42 ` Gerd Hoffmann [this message]
2011-08-31 13:35 ` bifferos
2011-08-31 20:03 ` [Qemu-devel] [PATCH v2] " bifferos
2011-09-01 8:43 ` [Qemu-devel] [PATCH] " Avi Kivity
2011-09-01 20:02 ` bifferos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F61AF.7040308@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=bifferos@yahoo.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).