From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz4jy-0000x9-K2 for qemu-devel@nongnu.org; Thu, 01 Sep 2011 06:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qz4js-00034v-Lc for qemu-devel@nongnu.org; Thu, 01 Sep 2011 06:43:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz4js-0002wL-EY for qemu-devel@nongnu.org; Thu, 01 Sep 2011 06:43:16 -0400 Message-ID: <4E5F61AF.7040308@redhat.com> Date: Thu, 01 Sep 2011 12:42:55 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> In-Reply-To: <4E5E5BF3.50801@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, bifferos On 08/31/11 18:06, Anthony Liguori wrote: > On 08/31/2011 09:35 AM, malc wrote: >> On Wed, 31 Aug 2011, Anthony Liguori wrote: >> >>> Upper case field names are not okay. If you think coding style isn't >>> clear, >>> that's a bug in coding style. > There's no benefit to going through and changing existing code but new > code needs to be consistent with the vast majority of code in the rest > of the tree. It's about overall code base consistency and maintainability. I don't see the point in being too picky about this. Especially consistency is a tricky thing. As USB has been raised in this thread already: The struct field names in the USBDesc* structs are actually consistent. They are consistent with the naming convention in the USB world, i.e. you'll find those funky names like "wMaxPacketSize" in the USB specs, in the "lsusb -v" output and probably other places too. Which makes alot of sense IMHO and is quite convenient when hacking the USB code. The USB naming convention and the qemu naming convention don't match, so it is impossible to please everybody here ... cheers, Gerd