From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QzI9c-0000Ys-9S
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 21:02:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QzI9b-0005Bx-5Z
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 21:02:44 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:58716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QzI9a-0005Br-PO
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 21:02:43 -0400
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p820gT92015511
	for <qemu-devel@nongnu.org>; Thu, 1 Sep 2011 18:42:29 -0600
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8212ffv144952
	for <qemu-devel@nongnu.org>; Thu, 1 Sep 2011 19:02:41 -0600
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p8218TMZ011823
	for <qemu-devel@nongnu.org>; Thu, 1 Sep 2011 19:08:29 -0600
Message-ID: <4E602B30.8040008@linux.vnet.ibm.com>
Date: Thu, 01 Sep 2011 21:02:40 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20110831143551.127339744@linux.vnet.ibm.com>
	<20110831143616.411365666@linux.vnet.ibm.com>
	<20110901181456.GL10989@redhat.com>
In-Reply-To: <20110901181456.GL10989@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V8 01/14] Support for TPM command line
	options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: chrisw@redhat.com, anbang.ruan@cs.ox.ac.uk, qemu-devel@nongnu.org, rrelyea@redhat.com, alevy@redhat.com, andreas.niederl@iaik.tugraz.at, serge@hallyn.com

On 09/01/2011 02:14 PM, Michael S. Tsirkin wrote:
> On Wed, Aug 31, 2011 at 10:35:52AM -0400, Stefan Berger wrote:
>> This patch adds support for TPM command line options.
>> The command line supported here (considering the libtpms based
>> backend) are
>>
>> ./qemu-... -tpm builtin,path=<path to blockstorage file>
>>
>> and
>>
>> ./qemu-... -tpmdev builtin,path=<path to blockstorage file>,id=<id>
>>             -device tpm-tis,tpmdev=<id>
>>
> builtin is a weird name in fact. Rename to libtpms?
Anyone have a particular opinion? If I renamed it, should I rename the 
files as well along with the function names that now all start with 
tpm_builtin_?

    Stefan