From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] Probe for libcheck by default.
Date: Fri, 02 Sep 2011 09:42:02 +0200 [thread overview]
Message-ID: <4E6088CA.4030005@redhat.com> (raw)
In-Reply-To: <4E5FDEE0.2010908@codemonkey.ws>
On 09/01/11 21:37, Anthony Liguori wrote:
> On 09/01/2011 10:42 AM, Gerd Hoffmann wrote:
>> Probe for libcheck and build checks (if found) by default.
>> Can be explicitly disabled using --disable-check-utests.
>>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>> configure | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I think we should convert the check tests to gtest, and then have make
> check use gtester and gtester-report generate a single report of all of
> the test cases.
I wouldn't object, that is *way* beyond the scope of this little patch
series though.
> We could then have build bot run make check and post the output.
Running "make check" in buildbot is indeed the motivation to do this ;)
> I don't
> want to end up with a bunch of non gtest unit tests...
This patch series doesn't add any. It just adds some build system glue
so "make check" runs the existing stuff.
cheers,
Gerd
next prev parent reply other threads:[~2011-09-02 7:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 15:42 [Qemu-devel] [PATCH 0/4] add "make check" Gerd Hoffmann
2011-09-01 15:42 ` [Qemu-devel] [PATCH 1/4] Probe for libcheck by default Gerd Hoffmann
2011-09-01 19:37 ` Anthony Liguori
2011-09-02 7:42 ` Gerd Hoffmann [this message]
2011-09-05 7:39 ` Markus Armbruster
2011-09-01 15:42 ` [Qemu-devel] [PATCH 2/4] move checks to separate variable Gerd Hoffmann
2011-09-01 15:42 ` [Qemu-devel] [PATCH 3/4] add "make check" target Gerd Hoffmann
2011-09-01 15:42 ` [Qemu-devel] [PATCH 4/4] add test-coroutine to checks Gerd Hoffmann
2011-09-05 7:55 ` [Qemu-devel] [PATCH 0/4] add "make check" Markus Armbruster
2011-10-24 18:43 ` Eduardo Habkost
2011-10-24 18:57 ` Anthony Liguori
2011-10-25 12:21 ` Kevin Wolf
2011-10-25 13:27 ` Gerd Hoffmann
2011-10-25 14:16 ` Kevin Wolf
2011-10-25 15:03 ` Eduardo Habkost
2011-10-25 15:22 ` Kevin Wolf
2011-10-26 20:49 ` Anthony Liguori
2011-10-27 8:20 ` Kevin Wolf
2011-10-27 17:58 ` Anthony Liguori
2011-10-27 21:22 ` Michael Roth
2011-10-25 15:54 ` Gerd Hoffmann
2011-10-25 16:30 ` Lucas Meneghel Rodrigues
2011-10-25 15:03 ` Anthony Liguori
2011-11-01 18:03 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6088CA.4030005@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).